Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in data node #20960

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

moesterheld
Copy link
Contributor

Description

Calls to data node's Opensearch endpoint _nodes show a deprecation warning in the logs. This change removes this deprecation warning.

/nocl internal change

Motivation and Context

fixes #20759

How Has This Been Tested?

Startup data node without this change
-> any call to _nodes from Graylog will show warning in Graylog logs
alternatively, call /api/datanodes/any/opensearch/_nodes endpoint directly, check Graylog logs

Startup data node with change
-> no warning is shown

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@todvora todvora merged commit d5bfa63 into master Nov 15, 2024
5 checks passed
@todvora todvora deleted the fix/20759-publish-address-data-node branch November 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust deprecated publish_address in data node
2 participants