Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch keystore used for key/truststore passwords #20923

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Nov 8, 2024

Move key/truststore passwords to Opensearch keystore, instead of putting them into the opensearch.yml config file.

Motivation and Context

Fixes #20926

How Has This Been Tested?

Existing integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review November 11, 2024 08:44
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.
I added a minimal change that uses the -x option for adding OS keystore secrets to avoid problems by bypassing the terminal prompt.

@moesterheld moesterheld merged commit ec1fd11 into master Nov 15, 2024
6 checks passed
@moesterheld moesterheld deleted the feature/datanode-passwords-keystore branch November 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure passwords in opensearch
2 participants