-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trait refactor #5562
Closed
Closed
Trait refactor #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xQwexx
force-pushed
the
trait-refactor
branch
2 times, most recently
from
December 28, 2023 21:50
c1eed95
to
a1c0041
Compare
xQwexx
force-pushed
the
trait-refactor
branch
3 times, most recently
from
January 4, 2024 14:50
9044c60
to
4bd6057
Compare
xQwexx
force-pushed
the
trait-refactor
branch
5 times, most recently
from
January 7, 2024 09:31
0dc3674
to
9d948d2
Compare
xQwexx
force-pushed
the
trait-refactor
branch
13 times, most recently
from
April 8, 2024 09:16
b469e21
to
cb43ff9
Compare
xQwexx
force-pushed
the
trait-refactor
branch
6 times, most recently
from
May 1, 2024 09:30
cfeabfb
to
15d1eeb
Compare
xQwexx
force-pushed
the
trait-refactor
branch
7 times, most recently
from
May 27, 2024 11:24
8e642bd
to
23b863a
Compare
Hey @xQwexx I'm closing this as I'm not planning to merge it and it generates noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @artf
I am working of refactoring of the Trait module because I wanted to build some custom input layouts but there was not existing generic ones that I could use, so I started to work on a generic InputViews (Backbone model attribute modifiers),
this would also enable to use it instead of PropertyView, TraitView and InputView so it will be much easier to maintain and understand
To a more reusable which would not depend on the component and trait to be a backbone model:
But I think this would require to break the current API for the Traits in some places, so I wanted to know what do you thinks of this before I do a clean pr (so this is a WIP branch of mine with some unrelated changes)