Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait refactor #5562

Closed
wants to merge 32 commits into from
Closed

Trait refactor #5562

wants to merge 32 commits into from

Conversation

xQwexx
Copy link
Contributor

@xQwexx xQwexx commented Dec 16, 2023

Hi @artf
I am working of refactoring of the Trait module because I wanted to build some custom input layouts but there was not existing generic ones that I could use, so I started to work on a generic InputViews (Backbone model attribute modifiers),
this would also enable to use it instead of PropertyView, TraitView and InputView so it will be much easier to maintain and understand

To a more reusable which would not depend on the component and trait to be a backbone model:

But I think this would require to break the current API for the Traits in some places, so I wanted to know what do you thinks of this before I do a clean pr (so this is a WIP branch of mine with some unrelated changes)

      let input = new TraitTextView(em, { name: 'route' })
      input.setTarget('name', this.model, { changeProp: true });
      this.$el.append(input.render().el);

@xQwexx xQwexx force-pushed the trait-refactor branch 2 times, most recently from c1eed95 to a1c0041 Compare December 28, 2023 21:50
@xQwexx xQwexx force-pushed the trait-refactor branch 3 times, most recently from 9044c60 to 4bd6057 Compare January 4, 2024 14:50
@xQwexx xQwexx force-pushed the trait-refactor branch 5 times, most recently from 0dc3674 to 9d948d2 Compare January 7, 2024 09:31
@xQwexx xQwexx force-pushed the trait-refactor branch 13 times, most recently from b469e21 to cb43ff9 Compare April 8, 2024 09:16
@xQwexx xQwexx force-pushed the trait-refactor branch 6 times, most recently from cfeabfb to 15d1eeb Compare May 1, 2024 09:30
@xQwexx xQwexx force-pushed the trait-refactor branch 7 times, most recently from 8e642bd to 23b863a Compare May 27, 2024 11:24
@artf
Copy link
Member

artf commented May 28, 2024

Hey @xQwexx I'm closing this as I'm not planning to merge it and it generates noise.
Let me know if you're open to discuss how to make the editor UI better with reusable web components as mentioned in a previous post.

@artf artf closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants