Fix memory leak where Python object refcount not decremented.

GrahamDumpleton · Aug 8, 2024 · e4e1999 · e4e1999
1 parent eaf1784
commit e4e1999
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/docs/release-notes/version-5.0.1.rst b/docs/release-notes/version-5.0.1.rst
@@ -12,3 +12,5 @@ Bugs Fixed
 * Fix issue which could result in process crashing when values were supplied
   for user/password/realm of HTTP basic authentication which weren't compliant
   with UTF-8 encoding format.
+
+* Fix memory leak in `check_password()` authentication hook handler.
diff --git a/src/server/mod_wsgi.c b/src/server/mod_wsgi.c
@@ -14926,6 +14926,7 @@ static authn_status wsgi_check_password(request_rec *r, const char *user,
                         if (str) {
                             adapter->r->user = apr_pstrdup(adapter->r->pool,
                                     PyString_AsString(str));
+                            Py_DECREF(str);
 
                             status = AUTH_GRANTED;
                         }