Uses Docker config in RetrieveRegistryCredentialsStep. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
approved these changes
Feb 19, 2018
| this.registry = registry; | ||
| } | ||
|
|
||
| public DockerCredentialRetriever withSuffix(String credentialHelperSuffix) { |
There was a problem hiding this comment.
Nit: maybe this should be called withCredentialHelperSuffix? or the class called DockerCredentialHelperRetreiverFactory?
There was a problem hiding this comment.
I'll rename DockerCredentialRetriever to DockerCredentialHelper and refactor this factory and method naming in a followup refactoring CL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Also adds a test for
RetrieveRegistryCredentialsStep.