Adds parser for Docker config. #102
Conversation
| @@ -8,6 +8,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| ## 0.1.2 | |||
| ### Added | |||
| - Use credentials from Docker config if none can be found otherwise ([]()) | |||
There was a problem hiding this comment.
This should be populated with the next PR that adds this functionality to RetrieveCredentialsStep.
| @@ -35,5 +37,10 @@ public static Authorization withBasicCredentials(String username, String secret) | |||
| return new Authorization("Basic", token); | |||
| } | |||
|
|
|||
| /** Creates an {@link Authorization} with a base64-encoded {@code username:password} string. */ | |||
There was a problem hiding this comment.
do we/can we ensure this is only used for docker-config consumed credentials?
There was a problem hiding this comment.
This is intended to be used with any basic authorization token, which are in the form of username:password.
There was a problem hiding this comment.
oh yeah, I didn't really remember if Authorization was part of the api, but I mean are we only creating Authorizations withBasicToken when using docker-config?
There was a problem hiding this comment.
Yea, the only place that uses this now is in the DockerConfigCredentialRetriever.
| public class DockerConfigCredentialRetriever { | ||
|
|
||
| private static final Path DOCKER_CONFIG_FILE = | ||
| Paths.get(System.getProperty("user.home")).resolve(".docker").resolve("config.json"); |
There was a problem hiding this comment.
is this true for windows/mac too?
There was a problem hiding this comment.
Yes, on windows, the user.home would give %USERPROFILE%, whereas on the unix systems, it gives $HOME.
https://docs.docker.com/engine/reference/commandline/login/#privileged-user-requirement states the location of the config file.
| * | ||
| * <p>Example: | ||
| * | ||
| * <pre{@code |
There was a problem hiding this comment.
do you need to close this pre tag with a >? It's rendering funny here.
Part of #101.
Need to still add the portion to actually use this in
RetrieveCredentialsStep.