-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting info and debug logs other than Errors #88
base: master
Are you sure you want to change the base?
Conversation
Adding custom resourceType and severity
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
this.serviceContext = {service: config.service || 'web'}; | ||
this.serviceContext = {service: config.service || 'web', | ||
resourceType: config.resourceType || 'reported_errors', | ||
severity: 'ERROR' || config.severity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you talk more about why you think severity should be stored in the config?
I would expect instead the severity to be provided every time an error is reported.
@@ -52,7 +52,10 @@ StackdriverErrorReporter.prototype.start = function(config) { | |||
this.projectId = config.projectId; | |||
this.targetUrl = config.targetUrl; | |||
this.context = config.context || {}; | |||
this.serviceContext = {service: config.service || 'web'}; | |||
this.serviceContext = {service: config.service || 'web', | |||
resourceType: config.resourceType || 'reported_errors', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are also adding resourceType in context.
I am supportive, but I recommend sending a different PR for this.
@steren I don't see anything on the Cloud Reporting API documentation about the |
Adding custom resourceType and severity