-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply max line length to 80 #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RissyRan
force-pushed
the
pylint
branch
2 times, most recently
from
March 4, 2024 19:54
ae9d226
to
f4fb57c
Compare
RissyRan
requested review from
jonb377,
will-cromar,
JackCaoG,
vanbasten23,
chandrasekhard2,
EricLeFort,
gkroiz and
sshahrokhi
as code owners
March 4, 2024 21:15
jonb377
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Ran!
EricLeFort
reviewed
Mar 4, 2024
will-cromar
approved these changes
Mar 4, 2024
chandrasekhard2
approved these changes
Mar 4, 2024
chandrasekhard2
approved these changes
Mar 5, 2024
sshahrokhi
approved these changes
Mar 5, 2024
vanbasten23
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added Pylint in this PR, and now apply max line length to 80 to match Google Style (we will have an internal repo for NPI work), with:
build
tolinting_check
Tests
Please describe the tests that you ran on Cloud VM to verify changes.
Instruction and/or command lines to reproduce your tests: ...
Upload dags to airflow, and have an simple run
List links for your tests (use go/shortn-gen for any internal link): ...
A few sanity tests:
Checklist
Before submitting this PR, please make sure (put X in square brackets):