Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing region tags to files used in tutorials #1001

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

bourgeoisor
Copy link
Member

This PR adds some region tags that were missing from files used in various tutorials. Licence headers have also been retroactively added where missing (in those files that were missing region tags, if applicable).

@bourgeoisor bourgeoisor requested review from yoshi-approver and a team as code owners November 1, 2023 19:45
Copy link

snippet-bot bot commented Nov 1, 2023

Here is the summary of changes.

You are about to add 16 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@@ -1,3 +1,18 @@
// Copyright 2019 Google LLC
Copy link
Collaborator

@NimJay NimJay Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: You even dug up the correct year of creation (of each file). It's a nit, but I appreciate the attention to detail!

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Approved. Thanks, again, Olivier!

@bourgeoisor bourgeoisor merged commit 925847c into main Nov 1, 2023
14 checks passed
@bourgeoisor bourgeoisor deleted the issue-add-missing-region-tags branch November 1, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants