Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE][conversation] Added Error messages when the error occurred & end_user_metadata in reply function #233

Merged
merged 0 commits into from
Sep 30, 2024

Conversation

jkshj21
Copy link
Collaborator

@jkshj21 jkshj21 commented Sep 13, 2024

Hello, Pat

I am requesting PR for the changes I made in core.conversation.py

As per our discussion, I made some adjustments.

Please let me know if you have any question. Thank you!

@jkshj21 jkshj21 requested a review from kmaphoenix September 13, 2024 02:39
@kmaphoenix
Copy link
Member

@jkshj21 just confirming, did you perform a git rebase before submitting your latest changes?

  • git checkout main
  • git pull
  • git checkout <your_branch>
  • git rebase main

When done this should show only your changes on top of whatever is latest in main.

@kmaphoenix kmaphoenix merged commit a79f08d into feature/reworked_DialogflowConversation Sep 30, 2024
6 checks passed
@kmaphoenix kmaphoenix force-pushed the feature/reworked_DialogflowConversation branch from 0ce3bad to 5221fa0 Compare September 30, 2024 13:49
@kmaphoenix kmaphoenix self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Should capture the error message after the error occurs in reply() in core.conversation.py
2 participants