Feature/cicd #196
Feature/cicd #196
Conversation
There was a problem hiding this comment.
Hi @sridharvikram there are several changes I've tagged in the files that are Python style updates that need to be made.
In addition, please run pylint locally to see all of the linter errors that need to be corrected.
You can also view the latest pylint run directly in the repo here:
https://github.com/GoogleCloudPlatform/dfcx-scrapi/actions/runs/9990092140/job/27632420520?pr=196
examples/dfcx_agent_cicd/cicd_code/shared/fullfillmentHelper.py
Outdated
Show resolved
Hide resolved
Similar to build_chat_engine_proto, this does the same but for search engines.
* chore: cleanup reqs * feat: add map inputs for faster processing * feat: add playbook processing support; add support for direct intent trigger * fix: cleanup creds code and remove outdated code * feat: new eval tool * feat: add script for making code context file * feat: add retry decorators * fix: expand testing folder * feat: add evaluations support * fix: linting * chore: update reqs * fix: dataframe setup and reporting * chore: bump version to 1.12.0
Update the link to point to the correct notebook vertex_agents_evals.ipynb
|
@kmaphoenix I have addressed all the lint issues you have mentioned and also fixed most of the lint errors that i ran in my IDE. Please re review it and do the needful. |
|
Hi @sridharvikram , did you perform a It's showing many edits to files that are not related to your CICD code and should not have been modified. If you did not perform a rebase, you should do this first. Otherwise it makes it very difficult to review all of your code. |
|
@sridharvikram yeah after looking at the branch some more there are many merge conflicts. Best course of action:
Otherwise we're going to have a lot of back and forth to get this fixed and you'll need to fix all of the merge conflicts locally. |
|
@kmaphoenix I have created this new PR #239 as suggested. Hence closing this one. Thanks |
I have added cicd pipeline code and readme doc to set it up for migrating agent under examples folder. I would like contribute this to SCRAPI library. Please review the changes