Simplify acceptance tests #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use default values for some environment variables to make it easier to run the tests
functicons
requested changes
Sep 15, 2023
| @@ -46,7 +46,7 @@ public class TestUtils { | |||
| public static final String MANAGED_TEST_TABLE_NAME = "managed_test"; | |||
| public static final String FIELD_TIME_PARTITIONED_TABLE_NAME = "field_time_partitioned"; | |||
| public static final String INGESTION_TIME_PARTITIONED_TABLE_NAME = "ingestion_time_partitioned"; | |||
| public static final String TEST_BUCKET_ENV_VAR = "TEST_BUCKET"; | |||
| public static final String INTEGRATION_BUCKET_ENV_VAR = "INTEGRATION_BUCKET"; | |||
There was a problem hiding this comment.
You might want to document this env variable in README with its default value.
| Preconditions.checkNotNull( | ||
| System.getenv("GOOGLE_CLOUD_PROJECT"), | ||
| "Please set the 'GOOGLE_CLOUD_PROJECT' environment variable"); | ||
| public static final String ACCEPTANCE_BUCKET_ENV_VAR = "ACCEPTANCE_BUCKET"; |
| @@ -773,19 +777,16 @@ You must use Java version 8, as it's the version that Hive itself uses. Make sur | |||
|
|
|||
| Acceptance tests create Dataproc clusters with the connector and run jobs to verify it. | |||
|
|
|||
| The following environment variables must be set and **exported** first. | |||
|
|
|||
| * `GOOGLE_APPLICATION_CREDENTIALS` - the full path to a credentials JSON, either a service account or the result of a | |||
functicons
requested changes
Sep 18, 2023
| @@ -711,7 +715,7 @@ export PROJECT=my-gcp-project | |||
| export BIGLAKE_LOCATION=us | |||
| export BIGLAKE_REGION=us-central1 | |||
| export BIGLAKE_CONNECTION=hive-integration-tests | |||
| export BIGLAKE_BUCKET=${USER}-biglake-test | |||
| export BIGLAKE_BUCKET=${PROJECT}-biglake-tests | |||
There was a problem hiding this comment.
Many projects have a : in their names, e.g., google.com:project, which makes this default bucket name invalid. At least, consider automatically converting : to _ or - here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default values for some environment variables to make it easier to run the tests