Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepntance test parameterization #103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

eyalbenivri
Copy link

During acceptance test, there is a need to setup a dataproc cluster which is handled by the test setup - however, there are some issues setting this up, when using a clean created GCP project:

  1. new projects doesn't necessarily have default VPC network. To avoid this, I added a SUBNET envrionment variable to allow user to choose the network to set this up in.
  2. By default, the Dataproc cluster is trying to use the default compute service account, which doesn't have the permissions to setup everything. I added an environment variable to establish which service account should be used to setup the dataproc cluster.
  3. I've changed the REGION constant of the acceptance tests base class to reuse the BIGLAKE_REGION environment variable as some users might have a project setup for this in a different region with subnets in different regions.

General cleanup:
Added a couple of entries to .gitignore of files that are auto-generated.

Eyal Ben Ivri and others added 4 commits August 21, 2023 16:45
…oc cluster creation

- Added SUBNET environment var for dataproc cluster creation
- Added SERVICE_ACCOUNT var for dataproc cluster creation
- /connector/.flattened-pom.xml
- sandbox-flavor

these files are generated during tests, and should not be tracked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants