-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: Feature usage chart pagination (#1013)
**Background:** When backfilling usage data, the feature usage chart displayed only a few data points, not the complete set. Network inspection revealed that multiple pages of data were successfully retrieved. **Repro:** 1. Navigate to: https://website-webstatus-dev.corp.goog/features/flexbox?showUsageChart **Solution:** This change aligns the feature usage chart pagination with the feature support chart's implementation: https://github.com/GoogleChrome/webstatus.dev/blob/b84a9ac02c2455dd6e5043615fc2a084f6980a46/frontend/src/static/js/components/webstatus-feature-page.ts#L621-L650 **Testing:** Comprehensive unit tests will be included with the refactor outlined in #964. To validate the pagination logic, this commit increases the number of data points displayed to over 100, enabling testing through Playwright. To optimize Playwright test performance, the initial data load specifically filters for the feature used in the feature page test, mitigating delays associated with loading excessive fake data.
- Loading branch information
1 parent
489104c
commit 27becb2
Showing
11 changed files
with
59 additions
and
50 deletions.
There are no files selected for viewing
Binary file modified
BIN
+40.7 KB
(120%)
....spec.ts-snapshots/matches-the-screenshot-with-usage-chart-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+83.3 KB
(130%)
...e.spec.ts-snapshots/matches-the-screenshot-with-usage-chart-1-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+44.6 KB
(120%)
...ge.spec.ts-snapshots/matches-the-screenshot-with-usage-chart-1-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.12 KB
(100%)
...ew-page.spec.ts-snapshots/display-with-chromium-usage-column-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+153 Bytes
(100%)
...iew-page.spec.ts-snapshots/display-with-chromium-usage-column-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+667 Bytes
(100%)
...view-page.spec.ts-snapshots/display-with-chromium-usage-column-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.