Reserve Updates #272
Reserve Updates #272
Conversation
Reserve Updates
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
|
Hi Hadar. Looking forward to review this :) Just one request, can you clean up the commit history and add more descriptive commit messages? Also, potentially splitting into multiple independent PRs if possible? Thanks, |
|
@peterje-tr sorry not gonna happen:) i'm happy to walk you through. |
sirpy
force-pushed
the
reserve-hack-fix
branch
from
396a45a to
4e82ee4
Compare
There was a problem hiding this comment.
Super nice work. Glad to see the changes. I have some comments
General Notes:
- This branch does not include recent changes from master. I think it would be proper to update it
- This PR would greatly benefit from being split into multiple independent PRs. It would make it much easier to review
| require( | ||
| _msgSender() == address(avatar) || _msgSender() == guardian, | ||
| "CompoundVotingMachine: not avatar or guardian" | ||
| ); |
There was a problem hiding this comment.
The Sayfer finding SAY-02 "Inconsistent Guardian Approval Requirement" seems to be still present
There was a problem hiding this comment.
line 429 was changed to make it a little bit clearer
here the status is fixed
https://sayfer.io/audits/smart-contract-audit-report-for-gooddollar/
There was a problem hiding this comment.
I can't find it in the link? Can you give me a more precise link?
There was a problem hiding this comment.
sirpy
force-pushed
the
reserve-hack-fix
branch
from
f420762 to
494ba11
Compare
No description provided.