IWB-7: allow using the "loading" property in DialogComponent #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/foreignManagement6_add_loading_spinner
…frankreed/foreignManagement7_dialog_spinner
FrankreedX
merged commit 472a708
into
frankreed/foreignManagement6_add_loading_spinner
1 check passed
FrankreedX
added a commit
that referenced
this pull request
Aug 15, 2024
* added blacklist hook * black list feature works * some unused stuff removal * waitlist seems to work * simplified removeBlacklist.js * pretty * removed transaction and hope that it works * fixed useBlackList.js hook firestore error, and made blacklist check functional * added refresh spinner for chooseTeam.js * updated invalidateKeys and fixed some styling * updated faulty invalidateKeys lists * kinda works lmao * updated the invalidateKeys again * navigation off chooseTeam works. Tech debt +1 * half finished progress * invite works * added waitlistError to ErrorComponent * pretty * text input moves above keyboard now * minor comment change Co-authored-by: Jake Gehrke <[email protected]> * changed console log wording in removeBlacklist Co-authored-by: Jake Gehrke <[email protected]> * removed copied over comment * updated tiny comment Co-authored-by: Jake Gehrke <[email protected]> * removed redundant log Co-authored-by: Jake Gehrke <[email protected]> * fix - added email to blacklist record * fix - added assertion if pfp exists when removing a user * added loading spinner to all buttons * can't invite already invited email * accepting invite will remove the invite * workin on remove user * added invitelist bug fix * migrating to react native paper Button's loading property for loading spinner * redundant comment Co-authored-by: Jake Gehrke <[email protected]> * :/ Co-authored-by: Jake Gehrke <[email protected]> * prevent double navigation to chooseTeam screen * remove half baked loading spinner on dialog component (will be its own pr) * changed dialog component's signature to contain loading * fixed "invalid-argument" * added key * last usage of Activity Indicator in a simple button replaced temp * Fixed Android keyboard avoiding for invitelist * removed redundant remove user fix * pretty * pretty * pretty * pretty * pretty * pretty * IWB-7: allow using the "loading" property in DialogComponent (#313) * added missing state from merge * simple fix * better align invite input with above elements * changed more "white" to use themecolors, and added spinner color to some buttons --------- Co-authored-by: Jake Gehrke <[email protected]> Co-authored-by: Jake Gehrke <[email protected]>
FrankreedX
added a commit
that referenced
this pull request
Aug 15, 2024
* added blacklist hook * black list feature works * some unused stuff removal * waitlist seems to work * simplified removeBlacklist.js * pretty * removed transaction and hope that it works * fixed useBlackList.js hook firestore error, and made blacklist check functional * added refresh spinner for chooseTeam.js * updated invalidateKeys and fixed some styling * updated faulty invalidateKeys lists * kinda works lmao * updated the invalidateKeys again * navigation off chooseTeam works. Tech debt +1 * half finished progress * invite works * added waitlistError to ErrorComponent * pretty * text input moves above keyboard now * minor comment change Co-authored-by: Jake Gehrke <[email protected]> * changed console log wording in removeBlacklist Co-authored-by: Jake Gehrke <[email protected]> * removed copied over comment * updated tiny comment Co-authored-by: Jake Gehrke <[email protected]> * removed redundant log Co-authored-by: Jake Gehrke <[email protected]> * fix - added email to blacklist record * fix - added assertion if pfp exists when removing a user * added loading spinner to all buttons * can't invite already invited email * accepting invite will remove the invite * workin on remove user * added invitelist bug fix * migrating to react native paper Button's loading property for loading spinner * redundant comment Co-authored-by: Jake Gehrke <[email protected]> * :/ Co-authored-by: Jake Gehrke <[email protected]> * prevent double navigation to chooseTeam screen * remove half baked loading spinner on dialog component (will be its own pr) * changed dialog component's signature to contain loading * fixed "invalid-argument" * debounced invite button * added key * last usage of Activity Indicator in a simple button replaced temp * Fixed Android keyboard avoiding for invitelist * removed redundant remove user fix * pretty * pretty * pretty * pretty * pretty * pretty * IWB-7: allow using the "loading" property in DialogComponent (#313) * added missing state from merge * simple fix * better align invite input with above elements * debounced invitelist without changing the color of the loading wheel * changed more "white" to use themecolors, and added spinner color to some buttons * debounced and error handled Unban --------- Co-authored-by: Jake Gehrke <[email protected]> Co-authored-by: Jake Gehrke <[email protected]>
FrankreedX
added a commit
that referenced
this pull request
Aug 16, 2024
* added blacklist hook * black list feature works * some unused stuff removal * waitlist seems to work * simplified removeBlacklist.js * pretty * removed transaction and hope that it works * fixed useBlackList.js hook firestore error, and made blacklist check functional * added refresh spinner for chooseTeam.js * updated invalidateKeys and fixed some styling * updated faulty invalidateKeys lists * kinda works lmao * updated the invalidateKeys again * navigation off chooseTeam works. Tech debt +1 * half finished progress * invite works * added waitlistError to ErrorComponent * pretty * text input moves above keyboard now * minor comment change Co-authored-by: Jake Gehrke <[email protected]> * changed console log wording in removeBlacklist Co-authored-by: Jake Gehrke <[email protected]> * removed copied over comment * updated tiny comment Co-authored-by: Jake Gehrke <[email protected]> * removed redundant log Co-authored-by: Jake Gehrke <[email protected]> * fix - added email to blacklist record * fix - added assertion if pfp exists when removing a user * added loading spinner to all buttons * can't invite already invited email * accepting invite will remove the invite * workin on remove user * added invitelist bug fix * migrating to react native paper Button's loading property for loading spinner * redundant comment Co-authored-by: Jake Gehrke <[email protected]> * :/ Co-authored-by: Jake Gehrke <[email protected]> * prevent double navigation to chooseTeam screen * remove half baked loading spinner on dialog component (will be its own pr) * changed dialog component's signature to contain loading * fixed "invalid-argument" * debounced invite button * added key * last usage of Activity Indicator in a simple button replaced temp * Fixed Android keyboard avoiding for invitelist * removed redundant remove user fix * pretty * pretty * pretty * pretty * pretty * pretty * IWB-7: allow using the "loading" property in DialogComponent (#313) * added missing state from merge * simple fix * better align invite input with above elements * debounced invitelist without changing the color of the loading wheel * changed more "white" to use themecolors, and added spinner color to some buttons * debounced and error handled Unban * Added status snackbar to the IWB buttons --------- Co-authored-by: Jake Gehrke <[email protected]> Co-authored-by: Jake Gehrke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.