[Fix] Add email to blacklist + Remove user fix #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artkolpakov
approved these changes
Aug 4, 2024
| await removePfp(getPfpName(teamId, userId)); | ||
| //remove pfp if there is one | ||
| if (userSnapshot.data().pfp !== "") { | ||
| await removePfp(getPfpName(teamId, userId)); |
There was a problem hiding this comment.
This made me realize that we currently lack functionality that allows users to delete their existing profile pictures and revert to the default profile picture. I will work on creating a ticket for this.
FrankreedX
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have added a simple addition to include the users email when they are banned for the purposes of supporting the blacklist management feature on pr #292. Additionally, I added an assertion if a pfp existed and which seems to fix the remove user issue.