Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle shot pill #155

Merged
merged 10 commits into from
Apr 29, 2024
Merged

Restyle shot pill #155

merged 10 commits into from
Apr 29, 2024

Conversation

Gehrkej
Copy link
Contributor

@Gehrkej Gehrkej commented Apr 16, 2024

Changes

Restyling of the navigationRectangle and regaining functionality after adjustments made for multi-requirement drills

Related Issues: Closes #111

Images of Changes

Before:

Image

After:
Image

Image

Image

@Gehrkej Gehrkej linked an issue Apr 16, 2024 that may be closed by this pull request
@FrankreedX
Copy link
Contributor

rebase and merge. The rebase shouldn't be hard because there's no conflicts

@Gehrkej Gehrkej force-pushed the Gehrkej/Restyle-Shot-Pill branch from 73e97eb to b61056b Compare April 25, 2024 07:17
@Gehrkej Gehrkej requested a review from FrankreedX April 25, 2024 08:04
@Gehrkej
Copy link
Contributor Author

Gehrkej commented Apr 25, 2024

Updated screenshots:

Andriod
image
image
image
image

IOS
image
image
image
image

Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if there's a click effect on these buttons too, but I can see the point of leaving this for another PR

components/input/navigationRectangle.js Show resolved Hide resolved
Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this Warning?
WARN (ADVICE) View #24763 of type ABI49_0_0RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component.

@Gehrkej
Copy link
Contributor Author

Gehrkej commented Apr 25, 2024

Can you fix this Warning? WARN (ADVICE) View #24763 of type ABI49_0_0RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component.

I meant to mention this in a comment, I tried resolve this by added a background color of "transparent" but it didn't work. attaching to a specific component didn't seem to work either in this case since we are just doing the View. I was able to just find the "Surface" component within React Native Paper and it allows for the elevation on both ios and android! Looking into a ripple right now

@FrankreedX
Copy link
Contributor

I found a solution with 1 View but I didn't expect the Surface component. It's a way better solution!

Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ripple looks good

@Gehrkej Gehrkej merged commit ac3b14e into layout Apr 29, 2024
1 check passed
@Gehrkej Gehrkej deleted the Gehrkej/Restyle-Shot-Pill branch April 29, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View all shots pill is too plain, esp for Line test
3 participants