-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle shot pill #155
Restyle shot pill #155
Conversation
rebase and merge. The rebase shouldn't be hard because there's no conflicts |
73e97eb
to
b61056b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if there's a click effect on these buttons too, but I can see the point of leaving this for another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this Warning?
WARN (ADVICE) View #24763 of type ABI49_0_0RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component.
I meant to mention this in a comment, I tried resolve this by added a background color of "transparent" but it didn't work. attaching to a specific component didn't seem to work either in this case since we are just doing the View. I was able to just find the "Surface" component within React Native Paper and it allows for the elevation on both ios and android! Looking into a ripple right now |
I found a solution with 1 View but I didn't expect the Surface component. It's a way better solution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ripple looks good
Changes
Restyling of the navigationRectangle and regaining functionality after adjustments made for multi-requirement drills
Related Issues: Closes #111
Images of Changes
Before:
After: