Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance UI features and styling #139

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Conversation

artkolpakov
Copy link
Contributor

This pull request implements several enhancements and adjustments to the user interface:

  1. Adjust Bar Chart Y-axis Styling: improved the visual presentation of the bar chart by adjusting the Y-axis styling for better readability, aligning metrics with the chart's lines. Ticket Nº107
example 1 example 2 example 3
Screenshot 2024-04-09 at 8 02 28 PM Screenshot 2024-04-09 at 8 02 53 PM Screenshot 2024-04-09 at 8 03 16 PM
  1. Remove Email Update from User Profile Settings Modal: removed the option for an email update from the user profile settings modal, as suggested by the coach. Tiket Nº132.
Screenshot 2024-04-09 at 8 06 22 PM
  1. Display User's Email on Profile Card: added functionality to display the user's email on the profile card. Tiket Nº115
Screenshot 2024-04-09 at 8 09 13 PM
  1. Adjust Snapping Positions for Profile Settings Modal: refactored the handling of snap points in the BottomSheetModal component to prevent full and half expansions. Additionally, ensured stability, as the snap points are now dynamically adjusted based on the visibility of the name/password input keyboard events (which wasn't working before). Tiket Nº121
name update snap points name + password update snap points keyboard input
IMG_6699 IMG_6700 IMG_6697

These changes collectively improve the usability and visual appeal of the application, enhancing the overall user experience.

Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall pretty good!

package-lock.json Outdated Show resolved Hide resolved
components/barChart.js Outdated Show resolved Hide resolved
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The signout button is still a little low imo (android, pixel 7 emulator)

image

  • confirm password is unreachable on android and can't scroll lower (see other comment about react native keyboard aware scrollview library
    • Edit: that library seemed incompatible with bottomsheet

app/content/profile/index.js Show resolved Hide resolved
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

remember to rebase

@solderq35
Copy link
Contributor

image

Might work for android "confirm password" issues, otherwise use https://reactnative.dev/docs/platform to add platform specific styling (keyboardawareview library doesn't seem compatible with bottomsheet)

@artkolpakov artkolpakov force-pushed the artkolpakov/UI-polishing branch from 814a105 to 5ce41af Compare April 11, 2024 07:08
@artkolpakov artkolpakov requested a review from solderq35 April 11, 2024 07:12
@solderq35
Copy link
Contributor

image

Increased vertical padding on Android so signout button is easier to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants