Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add option to create executable without adding ctest #300

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add option to create executable without adding ctest #300

wants to merge 1 commit into from

Conversation

kurtsansom
Copy link
Contributor

Added an option to skip adding the test in the add_pfunit_ctest.cmake function.

this is a workaround for #299

@tclune
Copy link
Member

tclune commented Jul 5, 2021

Could you redo this as a PR onto develop instead? I'm trying to reserve main for bug fixes.

@kurtsansom
Copy link
Contributor Author

I will shoot for getting to this by the end of the week

@tclune tclune self-requested a review July 23, 2021 11:59
@tclune tclune self-requested a review July 23, 2021 12:00
tclune
tclune requested changes Jul 23, 2021
View reviewed changes
Copy link
Member

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resubmit as a PR onto the develop branch. I try to reserve main for just hotfixes. (But I will be merging develop into main very soon.)

@kurtsansom
Copy link
Contributor Author

@tclune Apologies for not getting to this yet.

@kurtsansom kurtsansom changed the base branch from main to develop November 23, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtsansom @tclune