WIP: Convert to use ExternalProject #11
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to capture the experiments with
ExternalProject_Add
in GFE by myself and @tclune.At the moment, this seems to build GFE just fine. The issue at the moment is we aren't sure how to do the
tests
bit.For example, in current GFE you do:
mkdir build && cd build
cmake .. -DCMAKE_INSTALL_PREFIX=../install -DCMAKE_PREFIX_PATH=../install -DSKIP_OPENMP=ON
make install
cmake .. -DCMAKE_INSTALL_PREFIX=../install -DCMAKE_PREFIX_PATH=../install -DSKIP_OPENMP=ON
make tests
The second
cmake
is that the first time around, there was no pFUnit, so no tests were created to build by CMake. Now it sees the installed pFUnit and can make the tests.Now, with the
ExternalProject_Add
version you have to do:mkdir build && cd build
cmake .. -DCMAKE_INSTALL_PREFIX=../install -DCMAKE_PREFIX_PATH=../install -DSKIP_OPENMP=ON
make
(note NO install)rm -rf *
(the build directory must be removed)cmake .. -DCMAKE_INSTALL_PREFIX=../install -DCMAKE_PREFIX_PATH=../install -DSKIP_OPENMP=ON
make gFTL-tests
make yaFyaml-tests
So you have to run each set of tests individually.
The questions going forward:
ExternalProject_Add
to somehow "re-run" CMake for you?tests
target that when we domake tests
will run the tests for each subproject?