Verification of WorkSheetId at start execution #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good afternoon.
I have updated the plugin because I have faced the following scenario:
- When I use Google SpreadSheet, as an initial step, I select a SpreadSheetId, then I select a WorkSheetId.
When I administer a long Google SpreadSheet, in many I download in XLSX and update the data and then import it with the option to replace Sheet, that is where my ETL is broken and the WorkSheetId code is lost so my ETL no longer works.
I have implemented a solution to this problem, the GoogleSpreadsheetInput.java class and in the INIT method, I have added a validation method that does the following: Verifies that the WorkSheetId exists in the SpreadSheet, in case it does not exist by default it selects the sheet in zero position.
With this solution I have been able to solve the import problem by replacing Google SpreadSheet data time
Analyze the viability of adding this functionality in the project and then send it to the Pentaho MarketPlace
In case the project is not maintained, I can take charge of the project pdi-google-spreadsheet-plugin to add features that improve the integration with Google SpreadSheet.
Best regards.