Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Product Review Sentiment Pre-Built Model [resolves #221] #229

Closed
wants to merge 5 commits into from
Closed

Implement Product Review Sentiment Pre-Built Model [resolves #221] #229

wants to merge 5 commits into from

Conversation

irmakyucel
Copy link

@irmakyucel irmakyucel commented Mar 8, 2021 •
edited
Loading

  • Implement hyperparameter optimization.
  • Use optimized parameters in final model build and cv methods.
  • Use fit instead of partial_fit because PassiveAgressiveClassifier did not work well with partial fit.
  • Update README for 3-fold and 5-fold cross validation scores.
  • Add a test case for load and prediction of product review sentiment prebuilt model.

irmikyucel and others added 2 commits March 8, 2021 17:01
Implement Product Review Sentiment Pre-Built Model [resolves #221]
5902277 
- implement hyperparameter optimiation.
- use optimimied parameters in final model `build` and `cv` methods.
- use fit instead of partial_fit.
@dafajon
Remove commented sections.
b395a7d
@husnusensoy
Copy link
Contributor

can you reimplement the model using icu tokenizer.

@husnusensoy
Copy link
Contributor

Score is too low. Please try to find root cause and use a classifier with predict_proba function

@husnusensoy husnusensoy reopened this Mar 26, 2021
@husnusensoy
Copy link
Contributor

@irmakyucel please do ensure that

  1. you send your pull request to develop branch
  2. You sync your ( by merge ) feature branch with development branch first and resolve conflicts.
  3. @dafajon kindly requesting your support.

@husnusensoy husnusensoy requested a review from dafajon March 26, 2021 20:48
@husnusensoy husnusensoy added the help wanted Extra attention is needed label Mar 26, 2021
@husnusensoy husnusensoy added pending Pending Merge Requests question Further information is requested and removed help wanted Extra attention is needed labels Apr 2, 2021
@dafajon dafajon mentioned this pull request Apr 8, 2021
Closed
@dafajon
Copy link
Contributor

dafajon commented Apr 8, 2021

This PR is re-implemented with #238 closing it.

@dafajon dafajon closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafajon dafajon Awaiting requested review from dafajon

Assignees

@irmakyucel irmakyucel

Labels
pending Pending Merge Requests question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irmakyucel @husnusensoy @dafajon