Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lance insert_into support #2613

Merged
merged 29 commits into from
Feb 9, 2024
Merged

feat: lance insert_into support #2613

merged 29 commits into from
Feb 9, 2024

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Feb 8, 2024

on top of #2605

tychoish and others added 22 commits February 6, 2024 15:44
@tychoish
feat: support inserts into mongodb
a42b6fc
@tychoish @greyscaled
fix: local file path resolution for json and bson (#2594)
35dc04c 
Co-authored-by: Grey <[email protected]>
@universalmind303 @tychoish
fix: optimize ddl subqueries (#2601)
a1dbbcc 
todo: add some unit tests for this.
@tychoish
feat: insert_into external lance table
9279ef2
@tychoish
impl inserts
42fbbdc
@tychoish
Merge remote-tracking branch 'origin/main' into tycho/mdb-insert-support
a878cb6
@tychoish
add tests
67899b0
@tychoish
Merge remote-tracking branch 'origin/main' into tycho/mdb-insert-support
e4732c4
@tychoish
fmt
1c9dcbf
@tychoish
spelling fix
4840ce2
@tychoish
update readme
25ab9e6
@tychoish
Merge branch 'tycho/mdb-insert-support' into tycho/lance-insert-path
135ea30
@tychoish
cr feedback
3c1ad21
@tychoish
Merge branch 'tycho/mdb-insert-support' into tycho/lance-insert-path
d22b145
@tychoish
fmt
75e65d7
@tychoish
Merge remote-tracking branch 'origin/main' into tycho/mdb-insert-support
83ca47e
@tychoish
fixspell
a274cf6
@tychoish
better debug
f5e1f0b
@tychoish
fix conn string
73f31e5
@tychoish
match file names
d3577df
@tychoish
fix name
0865bbd
@tychoish
Merge branch 'tycho/mdb-insert-support' into tycho/lance-insert-path
93e123b
universalmind303
universalmind303 suggested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few small changes, and some tests.

crates/datasources/src/lance/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/lance/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/lance/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/lance/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/lance/mod.rs Outdated Show resolved Hide resolved
@universalmind303 universalmind303 mentioned this pull request Feb 8, 2024
Merged
2 tasks
@tychoish tychoish changed the base branch from tycho/mdb-insert-support to main February 9, 2024 03:36
@tychoish tychoish enabled auto-merge (squash) February 9, 2024 20:11
@tychoish tychoish disabled auto-merge February 9, 2024 20:12
@tychoish tychoish enabled auto-merge (squash) February 9, 2024 20:41
@tychoish tychoish merged commit 5ded739 into main Feb 9, 2024
22 checks passed
@tychoish tychoish deleted the tycho/lance-insert-path branch February 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tychoish @universalmind303