Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local file path resolution for json and bson #2594

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Feb 3, 2024

On top of #2593

Resolves #2589

This does not, I think, fix the globbing issue as I had hoped, but it does fix local path canonicalization and tilde expansion.

@tychoish tychoish linked an issue Feb 3, 2024 that may be closed by this pull request
Base automatically changed from tycho/bson-timestamp-fixes to main February 3, 2024 14:57
@tychoish
Copy link
Contributor Author

tychoish commented Feb 5, 2024

I'd like this to go in before #2595.

Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tychoish tychoish enabled auto-merge (squash) February 6, 2024 15:09
@tychoish tychoish merged commit ef187f4 into main Feb 6, 2024
22 checks passed
@tychoish tychoish deleted the tycho/bson-file-path-resolution branch February 6, 2024 15:25
tychoish added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bson doesn't work with relative paths
2 participants