Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules in gix #983

Merged
merged 10 commits into from
Aug 21, 2023
Merged

submodules in gix #983

merged 10 commits into from
Aug 21, 2023

Conversation

Byron
Copy link
Member

@Byron Byron commented Aug 17, 2023 •
edited
Loading

Follow-up of #977

Tasks

  • open module file from all possible locations with caching
  • submodule type with ability to obtain its repository
  • listing of submodules
  • expose all remaining submodule attributes
  • submodule repository (with explanation of the states it can be in)
  • be sure the opened submodule repo knows its 'kind'
  • assure we can read all supported ways a submodule repo is stored
  • update git2 comparison with pathspecs and submodule APIs
  • gix index entries with --recurse-submodules

Out of scope/Next PR

  • gix submodule list
  • checkout of submodules (probably needs some more research to see how cargo needs it, they kind of handle it themselves anyway so let's go for that as well)

@Byron Byron force-pushed the submodule-in-gix branch 8 times, most recently from 31dc54b to a051ade Compare August 18, 2023 13:55
@Byron Byron force-pushed the submodule-in-gix branch 4 times, most recently from c467f66 to ee24dbc Compare August 20, 2023 19:13
@Byron
feat: add FileSnapshot::new() to create free-floating instances.
2650843
@Byron
fix: Assure gix-submodule works with Rust 1.65.
8172f0e 
The previous version of this loop, possibly preferable, ran into
a borrow-check issue that was no more from Rust 1.70 onwards.
@Byron
feat!: make API less error prone by enforcing overrides at instantiat…
4a443e4 
…ion time.

It's made so that overrides can still be applied at a later point.
@Byron
feat!: remove File::names_and_active_state() in favor of `File::is_…
3503f49 
…active_platform()`.

With this platform it's possible to make repeated checks to see if a named submodule is active.
@Byron
feat: add `cache::state::attributes|ignore::Source::adjust_for_bare()…
a7c0880 
…` to use non-worktree versions of source easily.
@Byron
feat: add Submodule type to represent a declared submodule.
59bb3c4
@Byron
feat: add Worktree::pathspec() to easily get worktree-scoped pathsp…
28249bd 
…ec searches.
@Byron
adapt to changes in gix
9fe3052
@Byron Byron merged commit 36f7b78 into main Aug 21, 2023
17 checks passed
@Byron Byron deleted the submodule-in-gix branch August 21, 2023 12:04
@Byron Byron mentioned this pull request Aug 21, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Byron