Fix build on by disabling sha1-asm #946
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have found
sha1-asm
to break build on i686-pc-windows-gnu and i686-pc-windows-gnullvm targets. Unfortunatelysha1-asm
crates are in maintenance mode so they are unlikely to be fixed: RustCrypto/asm-hashes#60EDIT: I'll hold back to see if upstream bug gets fixed.