Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on by disabling sha1-asm #946

Closed
wants to merge 1 commit into from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jul 24, 2023

Hello,
We have found sha1-asm to break build on i686-pc-windows-gnu and i686-pc-windows-gnullvm targets. Unfortunately sha1-asm crates are in maintenance mode so they are unlikely to be fixed: RustCrypto/asm-hashes#60

EDIT: I'll hold back to see if upstream bug gets fixed.

@mati865 mati865 marked this pull request as draft July 24, 2023 22:03
@Byron
Copy link
Member

Byron commented Jul 25, 2023

Thanks for the fix! This configuration of sha1-asm is the biggest technical debt (that I am aware of) as it has the potential for failing builds while continuously giving me the feeling that this line isn't really working.
But maybe it is now, and I am looking forward to your feedback to see if it worked or not.

Ideally, of course, this CI here would be able to test for the issue, so if you have any hints on that it would be appreciated also.

Thanks for letting me know if it worked or not.

@ognevny
Copy link
Contributor

ognevny commented Aug 7, 2023

the bug got fixed, so now you can just bump sha1-asm version

@mati865
Copy link
Contributor Author

mati865 commented Aug 7, 2023

There is no action required on gitoxide side since new versions are semver compatible. The update should happen in starship repository.

I'm hoping to take care of the CI within next two weeks (unless somebody beats me to it, which I wouldn't mind), probably in similar fashion as in RustCrypto/asm-hashes#61

@mati865 mati865 closed this Aug 7, 2023
@Byron
Copy link
Member

Byron commented Aug 8, 2023

I will be looking forward to your help with this due to lack of experience on my side, but will make sure that the PR is merged quickly along with a release afterwards. Thanks in advance.

@mati865 mati865 deleted the i686-mingw-fix branch September 3, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sha1-asm fails to link on i686-pc-windows-gnu
3 participants