Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented is_path_owned_by_current_user for wasi. #1600

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

Earthmark
Copy link
Contributor

@Earthmark Earthmark commented Sep 21, 2024

Not that it's doing very much when wasi doesn't have a concept of current user.

For more context:

Emscripten does have a concept of user, so this isn't a valid solution for that target.

This is part of trying to get this to build with wasi as a build target, AKA: #463

This gets gix-sec building for wasi.

Not that it's doing very much when wasi doesn't have a concept of current user.

This is part of trying to get this to build with wasi as a build target.
@Earthmark
Copy link
Contributor Author

It turns out the wasm32-unknown-emscripten target already builds successfully for gix-sec.

I don't know if wasm32-unknown-unknown is a valid target, I don't believe that target has a concept of file IO, let alone users.

This would allow tests for crates that have partial support as well.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I think this should work and I have added a (hopefully working) test that will validate that.

@Byron Byron merged commit be2f093 into GitoxideLabs:main Sep 21, 2024
16 checks passed
@Earthmark Earthmark deleted the earthmark/wasi_identity branch September 21, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants