-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java Combat Sounds #55
base: master
Are you sure you want to change the base?
Conversation
Hey! Thanks for the PR. After some discussion internally, we've decided to wait with these changes until Geyser is providing a resource pack by default - to ensure that there are no cases where not having the pack can impact gameplay. |
Cool! At least this will possibly be considered sometime in the future again. I might go back and change the sound id to |
Adds the Combat Sounds from Java Edition to Geyser. Note that the strong and weak combat sounds are not included, this is because they are already in the games resources. Requires GeyserMC/mappings#94 to be accepted.