Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-v2): color consolidation and other fixes #1556

Open
wants to merge 7 commits into
base: PBE-5855-feat/react-native-video-design-v2
Choose a base branch
from

Conversation

kristian-mkd
Copy link
Contributor

@kristian-mkd kristian-mkd commented Nov 5, 2024

Overview

  • consolidates the theme colors
  • adds support for Light/Dark theme for the dogfood app
  • updates the Lobby screen per design-v2
  • updates iOS config so that iPad is target device as well
    • solves issues when the app is shown on iPad is not constrained in smaller screen size
  • fixes speech indicator issue to be animating only when the user is speaking
  • fixes participant name, network indicator and reaction position issues
  • updates the FLOATING_VIDEO_VIEW_STYLE width and height to bigger values according to new design-v2
  • removes hardcoded Lobby video height const from the SDK LOBBY_VIDEO_VIEW_HEIGHT
  • fixes call recording modal and bottom drawer orientation issues

Screenshots

ios ios ios ios

@kristian-mkd kristian-mkd changed the base branch from main to PBE-5855-feat/react-native-video-design-v2 November 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant