Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Video filters #799

Merged
merged 15 commits into from
Jan 9, 2025
Merged

feat: Video filters #799

merged 15 commits into from
Jan 9, 2025

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Nov 25, 2024

This PR adds Blur and Image background effects to our Flutter Video SDK.

Docs PR: https://github.com/GetStream/docs-content/pull/50

iOS

ios_filters.mp4

Android

android_filters.mp4

@Brazol Brazol marked this pull request as ready for review November 28, 2024 11:18
@Brazol Brazol requested a review from a team as a code owner November 28, 2024 11:18
@EvertonMJunior
Copy link

Hi! Thanks for this amazing job @Brazol, we are migrating from another provider to GetStream and the experience has been much better. Our usecase requires mainly the blur effects, and we already got it working both on iOS and Android with this PR. We have a due date of mid-January to deliver these changes to our clientes, so I was wondering, is adding video filters to the web implementation something that will be done soon? We have a big usage of our app on the web version, and we want to support blur on the web too, inside our app. We have some more context on the video calls that is already implemented on it.

# Conflicts:
#	packages/stream_video_push_notification/pubspec.yaml
@Brazol
Copy link
Contributor Author

Brazol commented Dec 30, 2024

Hi! Thanks for this amazing job @Brazol, we are migrating from another provider to GetStream and the experience has been much better. Our usecase requires mainly the blur effects, and we already got it working both on iOS and Android with this PR. We have a due date of mid-January to deliver these changes to our clientes, so I was wondering, is adding video filters to the web implementation something that will be done soon? We have a big usage of our app on the web version, and we want to support blur on the web too, inside our app. We have some more context on the video calls that is already implemented on it.

Thank you, @EvertonMJunior. I'm glad to hear that you've already found a use for this feature! Currently, we officially support only Android and iOS. However, we plan to focus on the web platform soon and aim to add support for all features there. This is one of our top priorities at the moment. Unfortunately, I can't provide a specific timeline for when this will be ready.

@Brazol Brazol requested a review from deven98 January 7, 2025 16:18
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol Brazol merged commit 06ab616 into main Jan 9, 2025
3 checks passed
@Brazol Brazol deleted the feat/video-filters branch January 9, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants