Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align: cleanup in member related methods inside Call #509

Merged
merged 5 commits into from
Nov 1, 2023
Merged

align: cleanup in member related methods inside Call #509

merged 5 commits into from
Nov 1, 2023

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Oct 26, 2023

No description provided.

@Brazol Brazol marked this pull request as ready for review October 26, 2023 15:24
@Brazol Brazol requested a review from a team as a code owner October 26, 2023 15:24
kanat
kanat approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deven98
deven98 requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'removeMembers' -> 'updateCallMembers'

deven98
deven98 requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to 'addMembers'?

deven98
deven98 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/stream_video/lib/src/coordinator/retry/coordinator_client_retry.dart Outdated Show resolved Hide resolved
packages/stream_video/lib/src/coordinator/open_api/coordinator_client_open_api.dart Outdated Show resolved Hide resolved
packages/stream_video/lib/src/coordinator/retry/coordinator_client_retry.dart Outdated Show resolved Hide resolved
@deven98 deven98 enabled auto-merge (squash) November 1, 2023 13:24
@deven98 deven98 merged commit 13f35b7 into main Nov 1, 2023
3 of 5 checks passed
@deven98 deven98 deleted the align/remove-member-from-call branch November 1, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deven98 deven98 deven98 approved these changes

@kanat kanat kanat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brazol @kanat @deven98