-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust layout and colors of the voice recording view #704
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,11 @@ public struct ColorPalette { | |
public lazy var reactionCurrentUserColor: UIColor? = UIColor(tintColor) | ||
public lazy var reactionOtherUserColor: UIColor? = textLowEmphasis | ||
public lazy var selectedReactionBackgroundColor: UIColor? = nil | ||
public var voiceMessageCurrentUserBackground: UIColor = .streamInnerBorder | ||
public var voiceMessageOtherUserBackground: UIColor = .streamBarsBackground | ||
public var voiceMessageCurrentUserRecordingBackground: UIColor = .streamBarsBackground | ||
public var voiceMessageOtherUserRecordingBackground: UIColor = .streamBarsBackground | ||
public var voiceMessageControlBackground: UIColor = .streamWhiteStatic | ||
Comment on lines
+82
to
+86
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We probably could have reused some of the existing Color Pallete colors so that customers could have the styling for free 🤔 On UIKit, we are using the existing background colours in the ColorPallete. So if a customer already set their Theme, the voice recording attachment will be styled for free. In this case, they will need to set the color for this specific component. Which kinda defeats the porpose of a "Theme". That is why most of the names in the color palette don't have context (ex: Background1, Background2, etc..) Especially for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I used exactly the same colors what we have in our Figma specs. These are slightly different from what the current palette has. Not sure what is the best way here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For customers, it's easier if we are explicit about the names of the colors. Naming like |
||
|
||
// MARK: - Composer | ||
|
||
|
@@ -114,6 +119,7 @@ private extension UIColor { | |
static let streamInnerBorder = mode(0xdbdde1, 0x272a30) | ||
static let streamHighlight = mode(0xfbf4dd, 0x333024) | ||
static let streamDisabled = mode(0xb4b7bb, 0x4c525c) | ||
static let streamBarsBackground = mode(0xffffff, 0x17191c) | ||
|
||
// Currently we are not using the correct shadow color from figma's color palette. This is to avoid | ||
// an issue with snapshots inconsistency between Intel vs M1. We can't use shadows with transparency. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we forgot about this one: #688
The recording view should also be themable