Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for bottom placement of reactions #388

Merged
merged 28 commits into from
Nov 1, 2023
Merged

Conversation

martinmitrevski
Copy link
Contributor

🎯 Goal

Easily support bottom placement of reactions (below the message).

Docs would be part of the cookbook (separate repo / PR).

🧪 Testing

Needs to be turned on. Replace the code in AppDelegate, line 65, with this:

        let messageDisplayOptions = MessageDisplayOptions(reactionsPlacement: .bottom)
        let utils = Utils(
            messageListConfig: MessageListConfig(
                messageDisplayOptions: messageDisplayOptions,
                dateIndicatorPlacement: .messageList
            )
        )
        streamChat = StreamChat(chatClient: chatClient, utils: utils)

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner October 27, 2023 11:17
@github-actions
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarqubecloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 180 Code Smells

29.5% 29.5% Coverage
6.8% 6.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@martinmitrevski martinmitrevski merged commit 1ef823c into main Nov 1, 2023
9 of 10 checks passed
@martinmitrevski martinmitrevski deleted the reactions-variations branch November 1, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants