Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix flaky tests (refs #4070) #4451

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Jan 14, 2025

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (e2359b7) to head (216f26c).
Report is 5 commits behind head on move_routing_to_backend.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           move_routing_to_backend    #4451   +/-   ##
========================================================
  Coverage                    98.46%   98.46%           
========================================================
  Files                          269      269           
  Lines                        21392    21392           
========================================================
  Hits                         21064    21064           
  Misses                         328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 14, 2025

Geotrek-admin    Run #10855

Run Properties:  status check passed Passed #10855  •  git commit 426438e427 ℹ️: Merge 216f26ce82ed3f67fb4d577f77832d8b5c3e4e82 into e2359b7682c00b119a28d4e3c6c9...
Project Geotrek-admin
Branch Review refs/pull/4451/merge
Run status status check passed Passed #10855
Run duration 02m 04s
Commit git commit 426438e427 ℹ️: Merge 216f26ce82ed3f67fb4d577f77832d8b5c3e4e82 into e2359b7682c00b119a28d4e3c6c9...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@Chatewgne Chatewgne force-pushed the pgrouting_fix_flaky branch 3 times, most recently from cea70f4 to 2bcf55a Compare January 21, 2025 15:27
@Chatewgne Chatewgne force-pushed the pgrouting_fix_flaky branch from 2bcf55a to 82d452a Compare January 21, 2025 16:32
@Chatewgne Chatewgne changed the title 🐛 [BUG] Handle PGRouting fields to reset (refs #4070) 🐛 [BUG] Fix flaky tests (refs #4070) Jan 21, 2025
@Chatewgne Chatewgne marked this pull request as ready for review January 23, 2025 09:45
@Chatewgne Chatewgne force-pushed the pgrouting_fix_flaky branch from f29837c to 05a50ae Compare January 23, 2025 15:33
@Chatewgne Chatewgne force-pushed the pgrouting_fix_flaky branch 4 times, most recently from db2e577 to c7af791 Compare January 28, 2025 10:49
@submarcos
Copy link
Member

@Chatewgne Chatewgne force-pushed the pgrouting_fix_flaky branch from c7af791 to 216f26c Compare January 28, 2025 13:43
@Chatewgne Chatewgne merged commit d95d046 into move_routing_to_backend Jan 28, 2025
21 checks passed
@Chatewgne Chatewgne deleted the pgrouting_fix_flaky branch January 28, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants