Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [UI/UX] Restructure trek detail UI (refs #2967) #4422

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

justinefricou
Copy link
Contributor

@justinefricou justinefricou commented Dec 17, 2024

Description

This restructuring of the detail pages aims to reorganize the data into a different set of tabs so further developments can set up a loading system in which the data is only loaded when the user clicks on the associated tab.

Remaining work after this PR is merged:

  • UI/UX improvements for adding attached files / accessibility photos (implement a system similar to that of HD views?)
  • Set up the new loading system

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (perf_delay_filters@aef94d7). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             perf_delay_filters    #4422   +/-   ##
=====================================================
  Coverage                      ?   98.46%           
=====================================================
  Files                         ?      268           
  Lines                         ?    21362           
  Branches                      ?        0           
=====================================================
  Hits                          ?    21035           
  Misses                        ?      327           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 17, 2024

Geotrek-admin    Run #10737

Run Properties:  status check passed Passed #10737  •  git commit 1ba5962761 ℹ️: Merge 595363c54fb2fbfaad3906265056ed93af4df2ec into 4dba2fb8f4dbf97c182d9c27228f...
Project Geotrek-admin
Branch Review refs/pull/4422/merge
Run status status check passed Passed #10737
Run duration 01m 56s
Commit git commit 1ba5962761 ℹ️: Merge 595363c54fb2fbfaad3906265056ed93af4df2ec into 4dba2fb8f4dbf97c182d9c27228f...
Committer Justine Fricou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@justinefricou justinefricou changed the title Restructure trek detail UI 💄 [UI/UX] Restructure trek detail UI Jan 6, 2025
@justinefricou justinefricou force-pushed the restructure_trek_detail_ui branch 4 times, most recently from d6ed8a2 to 82b22e0 Compare January 7, 2025 10:28
@justinefricou justinefricou changed the title 💄 [UI/UX] Restructure trek detail UI 💄 [UI/UX] Restructure trek detail UI (refs #2967) Jan 7, 2025
docs/changelog.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
@justinefricou justinefricou force-pushed the restructure_trek_detail_ui branch from 82b22e0 to 9bd6a99 Compare January 7, 2025 11:18
@justinefricou justinefricou marked this pull request as ready for review January 7, 2025 11:32
@justinefricou justinefricou force-pushed the restructure_trek_detail_ui branch 4 times, most recently from a094287 to c0f6d05 Compare January 9, 2025 13:19
dependabot bot and others added 10 commits January 10, 2025 11:16
Bumps [charset-normalizer](https://github.com/Ousret/charset_normalizer) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/Ousret/charset_normalizer/releases)
- [Changelog](https://github.com/jawah/charset_normalizer/blob/master/CHANGELOG.md)
- [Commits](jawah/charset_normalizer@3.3.2...3.4.0)

---
updated-dependencies:
- dependency-name: charset-normalizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [persistent](https://github.com/zopefoundation/persistent) from 6.0 to 6.1.
- [Changelog](https://github.com/zopefoundation/persistent/blob/master/CHANGES.rst)
- [Commits](zopefoundation/persistent@6.0...6.1)

---
updated-dependencies:
- dependency-name: persistent
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [zodbpickle](https://github.com/zopefoundation/zodbpickle) from 4.0 to 4.1.1.
- [Changelog](https://github.com/zopefoundation/zodbpickle/blob/master/CHANGES.rst)
- [Commits](zopefoundation/zodbpickle@4.0...4.1.1)

---
updated-dependencies:
- dependency-name: zodbpickle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [redis](https://github.com/redis/redis-py) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/redis/redis-py/releases)
- [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES)
- [Commits](redis/redis-py@v5.2.0...v5.2.1)

---
updated-dependencies:
- dependency-name: redis
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.8.30 to 2024.12.14.
- [Commits](certifi/python-certifi@2024.08.30...2024.12.14)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [shapely](https://github.com/shapely/shapely) from 2.0.4 to 2.0.6.
- [Release notes](https://github.com/shapely/shapely/releases)
- [Changelog](https://github.com/shapely/shapely/blob/main/CHANGES.txt)
- [Commits](shapely/shapely@2.0.4...2.0.6)

---
updated-dependencies:
- dependency-name: shapely
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [transaction](https://github.com/zopefoundation/transaction) from 3.1.0 to 5.0.
- [Changelog](https://github.com/zopefoundation/transaction/blob/master/CHANGES.rst)
- [Commits](zopefoundation/transaction@3.1.0...5.0)

---
updated-dependencies:
- dependency-name: transaction
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cffi](https://github.com/python-cffi/cffi) from 1.16.0 to 1.17.1.
- [Release notes](https://github.com/python-cffi/cffi/releases)
- [Commits](python-cffi/cffi@v1.16.0...v1.17.1)

---
updated-dependencies:
- dependency-name: cffi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.4...3.1.5)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
- Move an object's related objects from the properties tab into their own tab
- Move accessibility pictures into the attached files tab
- Remove the display of the structure in the properties tab title
@justinefricou justinefricou force-pushed the restructure_trek_detail_ui branch from c0f6d05 to 595363c Compare January 10, 2025 10:19
@justinefricou justinefricou changed the base branch from master to perf_delay_filters January 10, 2025 10:20
@camillemonchicourt
Copy link
Member

Aperçu de la séparation des propriétés de l'objet et de ses objets liés :

image

C'est intéressant au niveau des performances de chargement des fiches détail, mais aussi en terme d'ergonomie et de navigation.
Je viens de montrer à un collègue utilisateur fréquent de GTA et il a bien apprécié la lisibilité que cela apporte.

@Chatewgne Chatewgne merged commit 5d1d27a into perf_delay_filters Jan 10, 2025
23 checks passed
@Chatewgne Chatewgne deleted the restructure_trek_detail_ui branch January 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants