Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter geometry #3125

Merged
merged 7 commits into from
Jun 3, 2022
Merged

Add filter geometry #3125

merged 7 commits into from
Jun 3, 2022

Conversation

LePetitTim
Copy link
Contributor

No description provided.

@LePetitTim LePetitTim force-pushed the add_filter_geometry branch from 6417590 to 19d5f3d Compare June 1, 2022 15:51
@LePetitTim LePetitTim requested review from submarcos and a team June 1, 2022 15:51
@cypress
Copy link

cypress bot commented Jun 1, 2022



Test summary

22 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit b9cfca0
Started Jun 2, 2022 3:58 PM
Ended Jun 2, 2022 4:01 PM
Duration 03:06 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@camillemonchicourt
Copy link
Member

A relier à #2515 si j'ai bien suivi, en lien avec le point 3.1 de l'analyse technique :

3.1 Problème avec le filtre

Le filtre servant à identifier les topologies cassées n’indique pas forcément les géométries invalides.

En effet, il se peut que les topologies soient dites « cassées » sans altérer la géométrie finale. Par exemple si un tronçon B découpe un tronçon A parcouru par un itinéraire, les deux tronçons A et A’ porteront le même ordre dans l’agrégation de l’itinéraire. La topologie sera considérée comme cassée. Or, il s’agit apparemment du comportement historique de Geotrek. Tant que le bon ordre est remonté dans la requête SQL (partie aléatoire du problème), la géométrie n’est pas altérée.

Solution court terme : différencier les deux filtres :

  • 1 pour les problèmes topologiques (ordre non respecté, trou)
  • 1 autre pour les géométrie cassées (linéaires différents de LineString (cas MultiLinestring et Point) → important pour savoir si un itinéraire publié est cassé

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #3125 (b9cfca0) into master (f5aa25a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3125   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         272      272           
  Lines       18792    18818   +26     
=======================================
+ Hits        18342    18368   +26     
  Misses        450      450           
Impacted Files Coverage Δ
geotrek/api/v2/functions.py 100.00% <100.00%> (ø)
geotrek/api/v2/views/sensitivity.py 100.00% <100.00%> (ø)
geotrek/common/functions.py 100.00% <100.00%> (ø)
geotrek/core/filters.py 100.00% <100.00%> (ø)
geotrek/core/models.py 96.29% <100.00%> (+0.01%) ⬆️
geotrek/infrastructure/models.py 100.00% <100.00%> (ø)
geotrek/land/models.py 100.00% <100.00%> (ø)
geotrek/maintenance/models.py 94.06% <100.00%> (+0.01%) ⬆️
geotrek/sensitivity/views.py 98.49% <100.00%> (+0.01%) ⬆️
geotrek/signage/models.py 97.84% <100.00%> (+<0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5aa25a...b9cfca0. Read the comment docs.

@submarcos submarcos merged commit 65cb892 into master Jun 3, 2022
@submarcos submarcos deleted the add_filter_geometry branch June 9, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants