Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the non-working geovec parsing. Move positional options to kwargs in parse_R,J,B #1616

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

joa-quim
Copy link
Member

No description provided.

Move positional options to kwargs in parse_R,J,B
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 97.75281% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (175263d) to head (65646e4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/psxy.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1616      +/-   ##
==========================================
+ Coverage   85.79%   85.81%   +0.02%     
==========================================
  Files         148      148              
  Lines       20700    20709       +9     
==========================================
+ Hits        17760    17772      +12     
+ Misses       2940     2937       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joa-quim joa-quim merged commit e20513d into master Dec 20, 2024
7 of 10 checks passed
@joa-quim joa-quim deleted the geovec-fixes branch December 20, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants