Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy <abbr> tag #97

Closed
wants to merge 2 commits into from
Closed

Fancy <abbr> tag #97

wants to merge 2 commits into from

Conversation

gjvnq
Copy link
Contributor

@gjvnq gjvnq commented May 30, 2022

Added CSS to allow for fancy usage of the tag. Also added JS to show the term definition on click so that mobile users aren't left out.

Screen Shot 2022-05-30 at 11 41 27

@ErdaradunGaztea
Copy link
Contributor

Ooooh, I like this one! Would use a lot for Polish translation, since we don't even have an abbreviation like AFAB/AMAB, so it's "o męskiej/żeńskiej płci przypisanej przy urodzeniu" everywhere and that's kinda long. I can volunteer to help with placing these in text (clean up some AFAB/AMAB placements, add HRT and others) if the proposal is accepted :)

I worry a little about printing GDB pages, since it's hard to print tooltips. Not to say it's a problem, I can see four more or less feasible solutions to that:

  • ignore completely
  • insert tooltips as text inside parentheses after the abbreviation (e.g. "AFAB (assigned female at birth)"); it could spam the text with abbreviations though, especially for constantly used AFABs/AMABs, though
  • add (manually written) "Dictionary" section as, say, the last or the second chapter (reasonably comfortable to use when printed)
  • insert footnotes (which will probably still be placed at the end when printing e.g. "View All" page, so not much difference to "Dictionary" section)

@gjvnq
Copy link
Contributor Author

gjvnq commented May 30, 2022 via email

@Twipped
Copy link
Contributor

Twipped commented May 31, 2022

This is something I've been wanting to do for a long time, but wanted to automate it against a proper glossary catalog.
There is an ABBR plugin for markdown-it that we could tie in. https://github.com/markdown-it/markdown-it-abbr

@gjvnq
Copy link
Contributor Author

gjvnq commented May 31, 2022

This is something I've been wanting to do for a long time, but wanted to automate it against a proper glossary catalog. There is an ABBR plugin for markdown-it that we could tie in. https://github.com/markdown-it/markdown-it-abbr

That is great and will probaby make the whole thing easier.

@gjvnq
Copy link
Contributor Author

gjvnq commented Jun 12, 2022

This pull request is unecessary if #100 is merged,

@Twipped
Copy link
Contributor

Twipped commented Jan 2, 2023

Closing this in favor of #100.

@Twipped Twipped closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants