Skip to content

Commit

Permalink
fix: update core-v3 dep, silence warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
lekhovitsky committed Jul 17, 2024
1 parent 8dee3b7 commit d870794
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion contracts/test/unit/BoundedPriceFeed.unit.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ contract BoundedPriceFeedUnitTest is Test {
}

/// @notice U:[BPF-2]: Price feed has correct metadata
function test_U_BPF_02_price_feed_has_correct_metadata() public {
function test_U_BPF_02_price_feed_has_correct_metadata() public view {
assertEq(priceFeed.decimals(), 8, "Incorrect decimals");
assertEq(priceFeed.description(), "TEST / USD bounded price feed", "Incorrect description");
assertTrue(priceFeed.skipPriceCheck(), "Incorrect skipPriceCheck");
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/unit/CompositePriceFeed.unit.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ contract CompositePriceFeedUnitTest is Test {
}

/// @notice U:[CPF-2]: Price feed has correct metadata
function test_U_CPF_02_price_feed_has_correct_metadata() public {
function test_U_CPF_02_price_feed_has_correct_metadata() public view {
assertEq(priceFeed.decimals(), 8, "Incorrect decimals");
assertEq(priceFeed.description(), "(TEST / ETH) * (ETH / USD) composite price feed", "Incorrect description");
assertTrue(priceFeed.skipPriceCheck(), "Incorrect skipPriceCheck");
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/unit/LPPriceFeed.unit.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ contract LPPriceFeedUnitTest is Test {
}

/// @notice U:[LPPF-2]: Price feed has correct metadata
function test_U_LPPF_02_price_feed_has_correct_metadata() public {
function test_U_LPPF_02_price_feed_has_correct_metadata() public view {
assertEq(priceFeed.decimals(), 8, "Incorrect decimals");
assertEq(priceFeed.description(), "TEST / USD LP price feed", "Incorrect description");
assertTrue(priceFeed.skipPriceCheck(), "Incorrect skipPriceCheck");
Expand Down
4 changes: 2 additions & 2 deletions contracts/test/unit/ZeroPriceFeed.unit.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ contract ZeroPriceFeedUnitTest is Test {
}

/// @notice U:[ZPF-1]: Price feed has correct metadata
function test_U_ZPF_01_price_feed_has_correct_metadata() public {
function test_U_ZPF_01_price_feed_has_correct_metadata() public view {
assertEq(priceFeed.decimals(), 8, "Incorrect decimals");
assertEq(priceFeed.description(), "Zero price feed", "Incorrect description");
assertTrue(priceFeed.skipPriceCheck(), "Incorrect skipPriceCheck");
}

/// @notice U:[ZPF-2]: `latestRoundData` works as expected
function test_U_ZPF_02_latestRoundData_works_as_expected() public {
function test_U_ZPF_02_latestRoundData_works_as_expected() public view {
(, int256 answer,,,) = priceFeed.latestRoundData();
assertEq(answer, 0, "Incorrect answer");
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/unit/updatable/PythPriceFeed.unit.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ contract PythPriceFeedUnitTest is TestHelper {
}

/// @notice U:[PYPF-1]: constructor sets correct values
function test_U_PYPF_01_constructor_sets_correct_values() public {
function test_U_PYPF_01_constructor_sets_correct_values() public view {
assertEq(pf.description(), "USDC / USD Pyth price feed", "Price feed description incorrect");

assertEq(pf.token(), token, "Price feed token incorrect");
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/unit/updatable/RedstonePriceFeed.unit.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ contract RedstonePriceFeedUnitTest is TestHelper, RedstoneConstants {
}

/// @notice U:[RPF-1]: constructor sets correct values
function test_U_RPF_01_constructor_sets_correct_values() public {
function test_U_RPF_01_constructor_sets_correct_values() public view {
assertEq(pf.description(), "USDC / USD Redstone price feed", "Incorrect description");

assertEq(pf.dataServiceId(), "mock-data-service", "Incorrect data service id");
Expand Down
2 changes: 1 addition & 1 deletion lib/@gearbox-protocol/core-v3
Submodule core-v3 updated 46 files
+0 −4 .gitmodules
+1 −0 contracts/core/AccountFactoryV3.sol
+1 −0 contracts/core/BotListV3.sol
+2 −1 contracts/core/GearStakingV3.sol
+1 −0 contracts/core/PriceOracleV3.sol
+5 −2 contracts/credit/CreditConfiguratorV3.sol
+8 −11 contracts/credit/CreditFacadeV3.sol
+6 −1 contracts/credit/CreditManagerV3.sol
+0 −9 contracts/interfaces/IExceptions.sol
+0 −5 contracts/interfaces/IPoolV3.sol
+2 −4 contracts/pool/GaugeV3.sol
+7 −5 contracts/pool/PoolQuotaKeeperV3.sol
+24 −31 contracts/pool/PoolV3.sol
+5 −4 contracts/pool/PoolV3_USDT.sol
+3 −4 contracts/pool/TumblerV3.sol
+2 −3 contracts/test/helpers/IntegrationTestHelper.sol
+14 −16 contracts/test/integration/credit/CreditConfigurator.int.t.sol
+7 −5 contracts/test/integration/governance/GaugeMigration.int.t.sol
+5 −3 contracts/test/integration/governance/QuotaRates.int.t.sol
+6 −3 contracts/test/lib/helper.sol
+5 −4 contracts/test/mocks/pool/PoolMock.sol
+5 −3 contracts/test/mocks/pool/PoolQuotaKeeperMock.sol
+5 −8 contracts/test/suites/PoolFactory.sol
+1 −2 contracts/test/unit/core/AccountFactoryV3.unit.t.sol
+3 −0 contracts/test/unit/core/GearStakingV3.unit.t.sol
+1 −1 contracts/test/unit/core/PriceOracleV3.unit.t.sol
+16 −3 contracts/test/unit/credit/CreditFacadeV3.unit.t.sol
+3 −8 contracts/test/unit/credit/CreditFacadeV3Harness.sol
+34 −1 contracts/test/unit/credit/CreditManagerV3.unit.t.sol
+13 −8 contracts/test/unit/credit/CreditManagerV3Harness.sol
+4 −4 contracts/test/unit/libraries/BitMask.unit.t.sol
+6 −6 contracts/test/unit/libraries/CreditLogic.unit.t.sol
+6 −5 contracts/test/unit/pool/GaugeV3.unit.t.sol
+1 −1 contracts/test/unit/pool/GaugeV3Harness.sol
+1 −1 contracts/test/unit/pool/LinearInterestRateModelV3.unit.t.sol
+5 −5 contracts/test/unit/pool/PoolQuotaKeeperV3.unit.t.sol
+65 −79 contracts/test/unit/pool/PoolV3.unit.t.sol
+4 −7 contracts/test/unit/pool/PoolV3Harness.sol
+3 −3 contracts/test/unit/pool/TumblerV3.unit.t.sol
+35 −11 contracts/test/unit/traits/USDT_Transfer.unit.t.sol
+18 −0 contracts/test/unit/traits/USDT_TransferHarness.sol
+4 −1 contracts/traits/ACLTrait.sol
+4 −1 contracts/traits/ContractsRegisterTrait.sol
+1 −0 contracts/traits/ControlledTrait.sol
+16 −2 contracts/traits/USDT_Transfer.sol
+0 −1 remappings.txt

0 comments on commit d870794

Please sign in to comment.