Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow never-type goals in lockout #13

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RasmusAntons
Copy link
Contributor

After transitioning from a different mod for lockout, we wanted to be able to reimplement some of the goals in a datapack, especially negative goals that prohibit you from doing something in the game.

This code probably isn't great, but it adds a possible implementation for that. The logic is that initially every team is eligible to get the goal, shown by a split background colour. Once all but one team have lost the condition, that last team gets the point.

Screenshot_20240512_212319

This probably shouldn't be active by default because it requires some consideration for goals. The goals need to either be easy to get accidentally, like "never take fall damage" or be possible for other teams to enforce, like "never die" (especially when playing with a player tracker). I added the start parameter --allow-never-goals-in-lockout for that.

@RasmusAntons RasmusAntons force-pushed the allow-never-goals-in-lockout branch 2 times, most recently from c22c5bd to ac58085 Compare May 27, 2024 15:11
Copy link
Owner

@Gaming32 Gaming32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just small things. However, I have another issue I'd like to bring up. If the last goal is a never goal, nothing special is done. It should be made such that the game immediately ends in this case. The logic for immediately ending a lockout is already there, so you just need to make it run that in this case.

Copy link
Owner

@Gaming32 Gaming32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Still needs a big test, obviously.

Copy link
Owner

@Gaming32 Gaming32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot. There still needs to be a check for if all the remaining goals are never goals, and triggering an immediate end if so.

@RasmusAntons
Copy link
Contributor Author

Oh, I forgot. There still needs to be a check for if all the remaining goals are never goals, and triggering an immediate end if so.

Would it be an option to make goals that will be skipped if nothing else is left another special tag? Some never goals would be okay at the end of the game, for example a game tied on 12-12 with "never die" left (if you're playing with a player tracker and are able to find and attack the other team).

@RasmusAntons RasmusAntons marked this pull request as draft June 1, 2024 22:50
@RasmusAntons
Copy link
Contributor Author

During playtesting today we also found out that a negative goal being awarded doesn't trigger the check for game winning so I'll work on that too.

@RasmusAntons
Copy link
Contributor Author

I think this works, but I'm not sure if the stalemate tag could cause confusion, being only relevant for lockout gamemode.

@RasmusAntons RasmusAntons marked this pull request as ready for review June 2, 2024 22:23
@Gaming32
Copy link
Owner

I'd prefer if the stalemate tag was the default case, since most never goals will lead to a stalemate if lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants