Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderOneLine should render to one line #1759

Merged
merged 3 commits into from
Oct 1, 2024
Merged

renderOneLine should render to one line #1759

merged 3 commits into from
Oct 1, 2024

Conversation

glguy
Copy link
Member

@glguy glguy commented Oct 1, 2024

Previously the implementation was using layoutCompat with the hope that this operation rendered to a single line. It doesn't. This function is only used in the obscure :dumptests command where rendering to a single line is important for the file format.

Previously the implementation was using layoutCompat with the hope that this operation rendered to a single line. It doesn't. This function is only used in the obscure :dumptests command where rendering to a single line is important for the file format.
@glguy glguy self-assigned this Oct 1, 2024
Copy link
Member Author

@glguy glguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test this easily with our current test framework. It improves the formatting of random output, so simple gold testing isn't going to cut it.

@RyanGlScott
Copy link
Contributor

It improves the formatting of random output, so simple gold testing isn't going to cut it.

Will the random output be deterministic if you call :set-seed beforehand?

@glguy
Copy link
Member Author

glguy commented Oct 1, 2024

Link issue #1314

@glguy glguy merged commit c7504ea into master Oct 1, 2024
49 checks passed
@glguy glguy deleted the renderOneLine branch October 1, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants