Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.2.0 #1735

Closed
wants to merge 2 commits into from
Closed

Release 3.2.0 #1735

wants to merge 2 commits into from

Conversation

mccleeary-galois
Copy link
Contributor

No description provided.

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mccleeary-galois! A couple of process quibbles:

  • In a separate commit, please bump the version numbers to 3.2.0.99, which will be the next development version. That way, when we cut a release branch, we can include everything up to (but not including) the 3.2.0.99 commit.

  • On a similar note, you've named the branch for this PR release-3.2.0, which is the naming convention we've adopted for release branches. You probably don't want to name this PR's branch release-3.2.0, since GitHub is configured to delete PR branches once they're merged. I'd recommend naming this PR's branch something like prepare-release-3.2.0 instead to avoid this.

    Another reason to pick a name like prepare-release-3.2.0 is that the CI is configured to run release-specific CI steps on any branch that matches the regex release-** (see here). This is desirable when you push the release branch, but not as desirable when you're just submitting a PR, since those extra CI steps will needlessly spend CI runner cycles. Giving it a name like prepare-release-3.2.0 is an effective way of making the branch name not match that regex :)

@@ -1,6 +1,6 @@
Cabal-version: 2.4
Name: cryptol
Version: 3.1.0.99
Version: 3.2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 3.2.0, not 3.2.0.0. By convention, we only use quaternary version numbers for development versions.

@mccleeary-galois mccleeary-galois deleted the release-3.2.0 branch August 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants