Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML-KEM: Try to clean up the NTT implementations #156

Merged
merged 8 commits into from
Nov 5, 2024
Merged

ML-KEM: Try to clean up the NTT implementations #156

merged 8 commits into from
Nov 5, 2024

Commits on Oct 31, 2024

  1. mlkem: put NTT into a submodule #147

    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c480bcd View commit details
    Browse the repository at this point in the history

  2. mlkem: add Rq / Tq types and use them #147 

    This doesn't replace all uses of `Z_q_256`, but it gets all the easy
ones.
    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2474ff5 View commit details
    Browse the repository at this point in the history

  3. mlkem: bring ntt names into alignment #147 

    This replaces `'`s with suffixes explictly describing what type of data
each NTT function operates over.
    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f156af4 View commit details
    Browse the repository at this point in the history

  4. mlkem: add docs about allowing equivalence #147 

    This adds some documentation around the NTT module explaining where the
spec says it's allowed to choose any version of their algorithms that
are the same.
    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    311df71 View commit details
    Browse the repository at this point in the history

  5. mlkem: format properties correctly #147 

    Several properties didn't have correct `repl` commands in the
docstrings.
    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    76c018d View commit details
    Browse the repository at this point in the history

  6. mlkem: reorganize fast-NTT a little bit #147

    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5a6a4a5 View commit details
    Browse the repository at this point in the history

  7. mlkem: clean up NTT multiplication functions #147 

    - Adds docs to BitRev and contains its behavior a bit better
- Adjust spacing, naming, etc in MultiplyNTTs and BaseCaseMultiply
    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7294204 View commit details
    Browse the repository at this point in the history

  8. mlkem: condense naive NTT implementations #147 

    This doesn't make them spec adherent but it simplifies the section a bit.
    @marsella
    marsella committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    71a5776 View commit details
    Browse the repository at this point in the history