SHA3: clean up round functions #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes hard-coded round constants at a significant performance penalty.
4 tasks
b13decker
reviewed
Sep 24, 2024
b13decker
reviewed
Sep 24, 2024
b13decker
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Great comments and commit decomposition. That made the review very smooth. I didn't see any issues. I agree that the functions better match the specs now, and the properties to prove equivalence with the hardcoded fast versions are excellent. No changes requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #138.
This brings the round functions into closer alignment with the spec. I found that the implementation was significantly (> 8x) slower than before, so I added hardcoded versions (and equivalence properties!) for two of the functions that involved constants. This addressed most of the slowdown.
I don't think there's anything crazy happening here; I'm just looking for general gold-standard review.