feat: add int1d #118
Merged
feat: add int1d #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #118 will degrade performances by 30.76%Comparing Summary
Benchmarks breakdown
|
beckermr
commented
Sep 13, 2024
| @@ -45,7 +45,7 @@ about the inner workings of GalSim and how to code in JAX. | |||
| ## Current GalSim API Coverage | |||
|
|
|||
| <!-- start-api-coverage --> | |||
| JAX-GalSim has implemented 22.6% of the GalSim API. See the list below for the supported APIs. | |||
| JAX-GalSim has implemented 22.5% of the GalSim API. See the list below for the supported APIs. | |||
There was a problem hiding this comment.
A bug in how we count APIs means this dropped even though I added APIs. 🤦♂️
beckermr
commented
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 1d integration via quadax.
closes #66