Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: code clean up #117

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore: code clean up #117

merged 2 commits into from
Sep 13, 2024

Conversation

beckermr
Copy link
Collaborator

This PR is part of addressing #88.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #117 will improve performances by 55.27%

Comparing code-cleanup (83469ba) with main (047cf19)

Summary

⚡ 2 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark main code-cleanup Change
⚡ test_benchmarks_lanczos_interp[kval-conserve_dc-run] 644.9 µs 446.5 µs +44.43%
⚡ test_benchmarks_lanczos_interp[xval-conserve_dc-run] 1,210 µs 779.3 µs +55.27%

@beckermr
Copy link
Collaborator Author

pre-commit.ci autofix

@beckermr beckermr marked this pull request as ready for review September 12, 2024 23:41
ismael-mendoza
ismael-mendoza approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@beckermr beckermr merged commit 746975b into main Sep 13, 2024
7 checks passed
@beckermr beckermr deleted the code-cleanup branch September 13, 2024 00:50
@beckermr beckermr mentioned this pull request Sep 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismael-mendoza ismael-mendoza ismael-mendoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckermr @ismael-mendoza