Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-working shortcut editor #1799

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −480
Open

Remove non-working shortcut editor #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f010f00
Remove non-working shortcut editor
ferdnyc May 4, 2024
c809cb3
Merge branch 'main' into no-kb-editor
ferdnyc May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion data/org.gnome.Shell.Extensions.GSConnect.gresource.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
<file compressed="true" preprocess="xml-stripblanks">ui/preferences-command-editor.ui</file>
<file compressed="true" preprocess="xml-stripblanks">ui/preferences-device-panel.ui</file>
<file compressed="true" preprocess="xml-stripblanks">ui/preferences-section-row.ui</file>
<file compressed="true" preprocess="xml-stripblanks">ui/preferences-shortcut-editor.ui</file>
<file compressed="true" preprocess="xml-stripblanks">ui/preferences-window.ui</file>
<file compressed="true" preprocess="xml-stripblanks">ui/service-device-chooser.ui</file>
<file compressed="true" preprocess="xml-stripblanks">ui/service-error-dialog.ui</file>
Expand Down
1 change: 0 additions & 1 deletion data/ui/preferences-device-panel.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1803,7 +1803,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
<property name="can_focus">False</property>
<property name="hexpand">True</property>
<property name="selection_mode">none</property>
<signal name="row-activated" handler="_onShortcutRowActivated" swapped="no"/>
<accessibility>
<relation type="labelled-by" target="action-shortcuts-label"/>
</accessibility>
Expand Down
142 changes: 0 additions & 142 deletions data/ui/preferences-shortcut-editor.ui
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions src/preferences/device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import Pango from 'gi://Pango';

import Config from '../config.js';
import plugins from '../service/plugins/index.js';
import * as Keybindings from './keybindings.js';


// Build a list of plugins and shortcuts for devices
Expand Down Expand Up @@ -989,27 +988,6 @@ export const Panel = GObject.registerClass({
);
}

async _onShortcutRowActivated(box, row) {
try {
const keybindings = this.settings.get_value('keybindings').deepUnpack();
let accel = keybindings[row.action] || null;

accel = await Keybindings.getAccelerator(row.title, accel);

if (accel)
keybindings[row.action] = accel;
else
delete keybindings[row.action];

this.settings.set_value(
'keybindings',
new GLib.Variant('a{ss}', keybindings)
);
} catch (e) {
logError(e);
}
}

/**
* Advanced Page
*/
Expand Down
Loading