Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2568: Updated references to "universal" with "gpii-universal" #97

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

klown
Copy link
Member

@klown klown commented Feb 22, 2018

@javihernandez I took the time to update linux with respect to phase I of the big-bang. Here's a pull request, if it's useful to you.

@klown
Copy link
Member Author

klown commented Feb 22, 2018

ok to test

package.json Outdated
@@ -6,7 +6,7 @@
"bugs": "http://issues.gpii.net/browse/GPII",
"homepage": "http://gpii.net/",
"dependencies": {
"universal": "GPII/universal#1a3434d970cb484956eb18310683bdfe473123d6"
"gpii-universal": "GPII/universal#36433633d01e59028ffefe0b4fcc59ef7d3886b2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the last available version in EN PI EM, https://www.npmjs.com/package/gpii-universal 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, you must use it 😄

Copy link
Member Author

@klown klown Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, okay if I must -- coming up.

Aside: I based it on your change to windows master. But, I see @amb26 updated that just yesterday. Things change too fast here. ;-)

@javihernandez
Copy link
Member

Thanks for this pull request @klown!
I've already left you one comment, but in general, it looks really good. I would need some time to test and merge, but will do ASAP.

@javihernandez javihernandez self-assigned this Feb 22, 2018
@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/linux-tests/139/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/linux-tests/140/

@klown
Copy link
Member Author

klown commented Apr 3, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Apr 3, 2018

CI job passed: https://ci.gpii.net/job/linux-tests/154/

@klown
Copy link
Member Author

klown commented Apr 26, 2018

ok to test

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/linux-tests/158/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/linux-tests/159/

@klown
Copy link
Member Author

klown commented May 30, 2018

ok to test

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/linux-tests/163/

@gpii-bot
Copy link

gpii-bot commented Jun 1, 2018

CI job failed: https://ci.gpii.net/job/linux-tests/168/

@gpii-bot
Copy link

gpii-bot commented Jun 4, 2018

CI job failed: https://ci.gpii.net/job/linux-tests/169/

@gtirloni
Copy link
Contributor

gtirloni commented Jul 4, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jul 4, 2018

CI job failed: https://ci.gpii.net/job/linux-tests/172/

@javihernandez
Copy link
Member

ok to test

@gpii-bot
Copy link

gpii-bot commented Jul 6, 2018

CI job failed: https://ci.gpii.net/job/linux-tests/173/

@javihernandez
Copy link
Member

@klown can you update this with current master? Also, any ideas why it's failing this way? I'll take a more close look into it later if I have time.

@gpii-bot
Copy link

gpii-bot commented Jul 6, 2018

CI job failed: https://ci.gpii.net/job/linux-tests/174/

@klown
Copy link
Member Author

klown commented Jul 6, 2018

Hi @javihernandez

Thanks for looking into this!

@klown can you update this with current master?

Done (8a1c225). But I doubt it will pass CI (and it didn't).

Also, any ideas why it's failing this way? I'll take a more close look into it later if I have time.

I'm still investigating, but I think it has to do with the version of gpii-universal referenced in package.json, namely 0.3.0-dev.20180221T093422Z.50833c1. That's the version that must be used. From a high level, I don't think that version of universal works with the latest version of the linux code (the master branch).

My best guess is that the changes to linux due to GPII-2515, which were committed on May 23rd, introduced a dependency or dependencies on universal that 0.3.0-dev.20180221T093422Z.50833c1 lacks. But, I'm not sure what that is. As I said, I'm still investigating.

One possibility is to use a different version of gpii-universal from npmjs.com (there are 19 versions listed there), or do we have to use the release version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants