-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-2568: Updated references to "universal" with "gpii-universal" #97
base: master
Are you sure you want to change the base?
Conversation
ok to test |
package.json
Outdated
@@ -6,7 +6,7 @@ | |||
"bugs": "http://issues.gpii.net/browse/GPII", | |||
"homepage": "http://gpii.net/", | |||
"dependencies": { | |||
"universal": "GPII/universal#1a3434d970cb484956eb18310683bdfe473123d6" | |||
"gpii-universal": "GPII/universal#36433633d01e59028ffefe0b4fcc59ef7d3886b2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the last available version in EN PI EM, https://www.npmjs.com/package/gpii-universal 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, you must use it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, okay if I must -- coming up.
Aside: I based it on your change to windows master. But, I see @amb26 updated that just yesterday. Things change too fast here. ;-)
Thanks for this pull request @klown! |
CI job passed: https://ci.gpii.net/job/linux-tests/139/ |
CI job passed: https://ci.gpii.net/job/linux-tests/140/ |
ok to test |
CI job passed: https://ci.gpii.net/job/linux-tests/154/ |
ok to test |
CI job passed: https://ci.gpii.net/job/linux-tests/158/ |
CI job passed: https://ci.gpii.net/job/linux-tests/159/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/163/ |
Include patch to unmask and start packagekit.service
CI job failed: https://ci.gpii.net/job/linux-tests/168/ |
Fixed one more require() in gpii.js
CI job failed: https://ci.gpii.net/job/linux-tests/169/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/172/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/173/ |
@klown can you update this with current master? Also, any ideas why it's failing this way? I'll take a more close look into it later if I have time. |
CI job failed: https://ci.gpii.net/job/linux-tests/174/ |
Thanks for looking into this!
Done (8a1c225). But I doubt it will pass CI (and it didn't).
I'm still investigating, but I think it has to do with the version of My best guess is that the changes to linux due to GPII-2515, which were committed on May 23rd, introduced a dependency or dependencies on universal that One possibility is to use a different version of |
@javihernandez I took the time to update linux with respect to phase I of the big-bang. Here's a pull request, if it's useful to you.