GPII-442: Detect Running Solutions #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
information about what is running.
Fixed code blocks to display with newlines.
Firmed up the c++ code for the 'nodeprocesse' add-on: simply a bridge to gnome/linux library to generate a list of processes and information about each. Added numerous unit tests for the above, where most of the tests use an object that provides an API for processes. Next step: carve out the relevant functions into a non-test object that provides the same API.
Using nodejs path.basename() for one of the tests. Linting nodeprocesses_test.js
First checkin of processes object for querying running processes, checking their state, and reporting changes.
Modified processes.js to use full gpii.processes name. Added procDemo.js to show how to detect a change in state for orca.
Added ability to start with a non-running process, and detect when it launches.
Whitespace cleanup and other tidying.
Added ability to continuously check the state of a process and report when it changes from "running" to "not running" OR from "not running" to "running".
Cleaned up comments.
First pass at integrate node's event systme to fire an event when the process switches between running and not running, and vice versa.
Renamed gpii.processes.refreshPrcoInfo() to gpii.processes.updateProcInfo(), and made use of it.
Simplify the interface for setting up monitoring a process and responding to events.
Moved most of the unit tests that were in nodeprocesses_test.js for the nodeprocesses add-on to a processes_test.js to test the new processes.js. The latter contains the machinery for inspecting processes, and, specifically, their state.
Replaced Nodejs event emitter object with fluid event firer. Tweaked some of the function names.
Reconfigured the processes.js to declare fluid.defaults for and evented component, and updated the demo as appropriate.
Added "onStateChange" event to notify of any change in a process' state, and functions to tap into this event. Also, simplified hasStateChanged(), monitorStateChange() functions.
Added invokers findSolutionsByCommands() and findSolutionsByPids() that take lists of command names, or process ids, respectively, and search the live process list to find and return a list of process information structures that match.
Renamed the main folder from "processes" to "processReporter".
- renamed "processes.js" to "processReporter.js" - renamed "processes_test.js" to "processReporter_tests.js" - renamed "procDemo.js" to "processReporterDemo.js" - modified various names and namespaces to use "processReporter".
Updated the readme file to reflect the latest changes. Also tidied the code.
Added rationale for use of "command" property as a way of identifying a process.
Added the "shell:compileProcesses" and "shell:cleanProcesses" tasks to the main build and clean tasks.
Merge fire ball changes from upstream.
Modified test for path argument of a process to use the full path. Fixed test for launching and quiting Orca (via gsettings) to test the quit aspect only if Orca started in the first place.
|
CI job passed. |
|
ok to test |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
Improved context aware inokers for getting the platorm specific list of running processes.
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
ok to test |
1 similar comment
|
ok to test |
|
Hi @amatas. My last two "ok to test" didn't trigger CI (see above). It used to work. Any ideas? Thanks. |
|
ok to test |
1 similar comment
|
ok to test |
|
CI job passed. |
|
ok to test |
|
CI job passed. |
… bridge Removed getPlatformProcessList() and collapsed implementation into getProcessList().
|
CI job passed. |
|
ok to test |
…sion. Universal dependency points to the revision that includes the latest Process Reporter code.
|
CI job passed: https://ci.gpii.net/job/linux-tests/112/ |
|
CI job failed: https://ci.gpii.net/job/linux-tests/113/ |
Merge use of "gpii-universal" instead of "universal" into Linux ProcessReporter branch.
|
CI job failed: https://ci.gpii.net/job/linux-tests/151/ |
Added a "gpii-universal" missed from previous commit
|
CI job failed: https://ci.gpii.net/job/linux-tests/152/ |
Added one more "gpii-universal" missed from previous commits
|
CI job passed: https://ci.gpii.net/job/linux-tests/153/ |
|
CI job passed: https://ci.gpii.net/job/linux-tests/162/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amb26 Here is the process reporter branch for your review. The README.md in the .../node_modules/processReporter directory provides an outlines of the parts and how they fit together.
I am relatively new at writing fluid components, so please give advice.
Thanks!
(cc @kaspermarkus, the GPII-442 reporter)